[license] Handle missing license metadata (#227)#228
Merged
Conversation
Contributor
|
🚀 Preview is available for this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Closes #227
Motivation / Context
licensefield or leave it empty incomposer.json.License\Resolver::resolve(), causing aTypeErrorbefore the command could skip generation cleanly.Changes
null.Verification
composer dev-tools./vendor/bin/phpunit tests/License/ResolverTest.php tests/License/GeneratorTest.php tests/Console/Command/LicenseCommandTest.phpcomposer dev-tools tests -- --filter='License' --no-cachecomposer dev-tools code-style -- --jsoncomposer dev-tools refactor -- --jsoncomposer dev-tools phpdoc -- --jsoncomposer dev-tools changelog:checkgit diff --checklicense, rancomposer install, then rancomposer dev-tools license -- --dry-run --json; it skipped LICENSE generation cleanly without the previousTypeError. The temporary fixture was removed after the check.composer dev-toolswas also attempted, but this local shell still hits the existing nested process TTY failure (proc_open(/dev/tty): Failed to open stream: Device not configured) before the full gate can complete.Documentation / Generated Output
docs/updatedNo public docs or generated output changed; this is a defensive bug fix for missing metadata.
Changelog
CHANGELOG.mdentryReviewer Notes